Перевод приложения с Fragment/View на Compose#15
Open
malinaalina wants to merge 1 commit into
Open
Conversation
| @Composable | ||
| fun DiscountBadge( | ||
| modifier: Modifier = Modifier, | ||
| discountText: String, |
There was a problem hiding this comment.
по конвенции, аргументы без дефолтного значения должны идти первыми
| } | ||
| val context = LocalContext.current | ||
| val factory = component.getFactory() | ||
| val viewModel: DetailsViewModel = viewModel(factory = factory) |
There was a problem hiding this comment.
лучше вьюмодель создать снаружи экрана (например в composable) и передать готовую
| @Composable | ||
| fun ProductsContent( | ||
| isLoading: Boolean, | ||
| products: List<ProductState>, |
There was a problem hiding this comment.
в иделе List нужно заменить на ImmutableList из kotlinx.collections.immutable для стабильности аргументов
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Приложение переведено с Fragment/View на Compose, заменена навигация
app_release-classes.txt